Closed algochoi closed 1 year ago
I don't think an integration test adds much safety here beyond whats already been done in the algod tests.
What do you think about adding the path/response unit tests and calling it a day?
For example: https://github.com/algorand/algorand-sdk-testing/pull/245/files
I don't think an integration test adds much safety here beyond whats already been done in the algod tests.
What do you think about adding the path/response unit tests and calling it a day?
For example: https://github.com/algorand/algorand-sdk-testing/pull/245/files
I think some kind of E2E in go-algorand
or integration test in one repo ought to exist showing that the devmode timestamps are behaving as expected. Maybe this already exists, but I didn't spot such a test in a brief search. Maybe add this test somewhere in this file?
Alternatively we could implement a full end to end test for devmode APIs for only one SDK (e.g. Python) under the @devmode
integration tag and the rest can be tested with the path unit test?
What do you think about adding the path/response unit tests and calling it a day?
Added path/response tests here: https://github.com/algorand/algorand-sdk-testing/pull/276
Sounds good, I'll close this for now.
Adds tests for get/setting timestamp offsets in dev mode. Only confirms that the algod request/response is correct as a sanity check.
Example here: https://github.com/algorand/py-algorand-sdk/pull/468