search

algorand / algorand-sdk-testing

Testing framework for Algorand SDKs
MIT License
20 stars 35 forks source link

updating paths to include currencyGreaterThan param for 0 #302

Closed shiqizng closed 1 year ago

shiqizng commented 1 year ago

182.

py-algorand-sdk updates for these updated tests.

shiqizng commented 1 year ago

@algochoi I had to reorder the params because json serialization in Go orders the fields alphabetically. Please have another look.

winder commented 1 year ago

I think there are several other fields like this where the zero value is also a valid input

winder commented 1 year ago

Maybe it's just GT and LT: https://github.com/algorand/indexer/pull/484

shiqizng commented 1 year ago

I think there are several other fields like this where the zero value is also a valid input

maybe, we need to do some investigation to know if there are other parameters having the same issue.

shiqizng commented 1 year ago

The main issue here is that it seems we can no longer distinguish between unset and set to 0. Is this an issue?

Unset and 0 are handled using None in python, String in java and js, pointer in Go, and we have some tests in here that have unset currencyGreaterThan values, https://github.com/algorand/algorand-sdk-testing/blob/48bee3e9cceb4d41a7a251f48914ed56ed73dcba/features/unit/v2indexerclient_paths.feature#L279.

These tests remain unchanged, and all sdks are passing these tests.