search

algorand / algorand-sdk-testing

Testing framework for Algorand SDKs
MIT License
20 stars 35 forks source link

Fix algod error string #307

Closed jasonpaulos closed 9 months ago

jasonpaulos commented 9 months ago

Fix algod error string, which changed because of https://github.com/algorand/go-algorand/pull/5875

jasonpaulos commented 9 months ago

Fairly confident this was because of the structured error PR (5875), since this is the actual error string which caused a failure yesterday:

TransactionPool.Remember: transaction 35OEHPL5FD7UJSAPFVFHQYEFSRNE6ROP3EDIZ6IZRFFAKF4JFIYQ: logic eval error: pc=704 dynamic cost budget exceeded, executing intc_1: local program cost was 700. Details: app=1072, pc=704, opcodes=intc_1 // 1; pop; intc_1 // 1

from https://app.circleci.com/pipelines/github/algorand/js-algorand-sdk/1306/workflows/d935951b-4f64-4b80-a7ce-1a9a5de4ff51/jobs/7964

It's the app=1072 which I believe is new and from that PR.

Though, to your point, these tests only run on SDK PRs/commits, so it possible for errors to be possible but not seen for a while. Before this error, circle says the last successful run on the JS SDK was 9 days ago though, so I don't think this error has been around for long.

jannotti commented 9 months ago

I see, I misread the diff and was thinking you had to add the "Details" stuff, but you removed it. I guess this is a prefix match.