algorand / conduit

Algorand's data pipeline framework.
MIT License
37 stars 26 forks source link

bugfix: postgresql exporter delete task #119

Closed tzaffi closed 1 year ago

tzaffi commented 1 year ago

Summary

The delete task wasn't running because the exporter config is wasn't actually being set in the exporter struct.

This PR includes:

TODO

Issues

117

Test Plan

A new E2E test is introduced to ensure that the delete task works as expected. I tried running this new test against the original code, and it failed in the expected manner.

See: #121

codecov[bot] commented 1 year ago

Codecov Report

Merging #119 (af2eb5a) into master (442791a) will increase coverage by 2.69%. The diff coverage is 76.61%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   67.66%   70.36%   +2.69%     
==========================================
  Files          32       36       +4     
  Lines        1976     2500     +524     
==========================================
+ Hits         1337     1759     +422     
- Misses        570      646      +76     
- Partials       69       95      +26     
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) :arrow_up:
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/metadata.go 69.11% <ø> (ø)
conduit/plugins/config.go 100.00% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) :arrow_down:
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...gins/processors/filterprocessor/fields/searcher.go 77.50% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) :arrow_up:
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) :arrow_up:
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more