Open tzaffi opened 1 year ago
The pipeline's NextRound is updated at the end of every round but accessed in several contexts that could be running in go-routines. A workaround we use atomic.LoadUint64 but that is no longer considered a best practice.
atomic.LoadUint64
Consider using pipeline.NextRound.Load() and similar functions for updating the variable.
This exact approach may not be backwards compatible on some 32-bit systems: https://go101.org/article/memory-layout.html
Should wait until #128 is merged
Low
Problem
The pipeline's NextRound is updated at the end of every round but accessed in several contexts that could be running in go-routines. A workaround we use
atomic.LoadUint64but that is no longer considered a best practice.Solution
Consider using pipeline.NextRound.Load() and similar functions for updating the variable.
Caveat Emptor
This exact approach may not be backwards compatible on some 32-bit systems: https://go101.org/article/memory-layout.html
Dependencies
Should wait until #128 is merged
Urgency
Low