algorand / conduit

Algorand's data pipeline framework.
MIT License
37 stars 26 forks source link

Add credentials for telemetry #144

Open algochoi opened 1 year ago

algochoi commented 1 year ago

Summary

Adds telemetry credentials for our Opensearch dev cluster.

Test Plan

Push telemetry events on startup on local conduit instance.

codecov[bot] commented 1 year ago

Codecov Report

Merging #144 (60a010c) into master (442791a) will increase coverage by 4.16%. Report is 55 commits behind head on master. The diff coverage is 81.00%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   67.66%   71.82%   +4.16%     
==========================================
  Files          32       37       +5     
  Lines        1976     2747     +771     
==========================================
+ Hits         1337     1973     +636     
- Misses        570      675     +105     
- Partials       69       99      +30     
Files Changed Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) :arrow_up:
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/metadata.go 69.11% <ø> (ø)
conduit/plugins/config.go 100.00% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) :arrow_down:
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...gins/processors/filterprocessor/fields/searcher.go 77.50% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) :arrow_up:
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) :arrow_up:
... and 21 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

algochoi commented 1 year ago

Could you move the defaults into the code? That way they can be updated with a software update rather than going stale if we want to change them in the future.

@winder That makes sense since we will likely change the URI some time in the future. But moving the defaults in the code could make it harder for users to set their custom telemetry endpoints (changing source code and recompiling the binary seems a bit more cumbersome). Is this an okay tradeoff here?