search

algorand / generator

OpenAPI parser/generator.
9 stars 13 forks source link

Fix Go source generation with type = string and format = byte #30

Closed michaeldiamant closed 2 years ago

michaeldiamant commented 2 years ago

Patches an issue with Go []byte generation observed in https://github.com/algorand/go-algorand-sdk/pull/316#discussion_r872584788 by copying an analogous condition from go_templates/model.vm into go_templates/common_macros.vm.

michaeldiamant commented 2 years ago

Build passed in related go-algorand-sdk PR (https://github.com/algorand/go-algorand-sdk/pull/320) proving the fix works. Marking ready for review.

The PR presents a patch fix. It's my 1st time working in generator, so I'd appreciate feedback on whether or not a broader change is needed.