search

algorand / go-algorand-sdk

Algorand Golang SDK
https://pkg.go.dev/github.com/algorand/go-algorand-sdk/v2
MIT License
185 stars 95 forks source link

feat: add min-balance to account information model #626

Closed kieranroneill closed 3 months ago

kieranroneill commented 7 months ago

Summary

Simply exposes the min-balance in the Account model as defined in the REST API response.

As the API defines the min-balance as required, there should always be a value. As of now (19th January 2024), minimum balance should always be >= 100,000 microAlgos.

Closes #272.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

gmalouf commented 3 months ago

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

kieranroneill commented 3 months ago

@kieranroneill thanks for contributing, can you try rebasing this to give it another go?

Hey @gmalouf I have updated the PR with the latest version :)

gmalouf commented 3 months ago

I jusr realized that the Account struct is actually generated based on the specification file in indexer using the sdk codegen action that runs on this repository.

There is a draft PR open to add this: https://github.com/algorand/indexer/pull/1596, I'm looking into what tests need to go in before moving forward.

gmalouf commented 3 months ago

641 was just merged that addresses this (now that https://github.com/algorand/indexer/pull/1596) was merged