algorand / go-algorand

Algorand's official implementation in Go.
https://developer.algorand.org/
Other
1.35k stars 470 forks source link

Make `goal account changeonlinestatus` support `goal clerk send` lsig and msig flags #1597

Open ori-shem-tov opened 4 years ago

ori-shem-tov commented 4 years ago

Is your feature request related to a problem? Please describe.

When creating a changeonline/offline transaction with goal account changeonlinestatus it's impossible to sign it with a logic signature or multisig.

Describe the solution you'd like

Make goal account changeonlinestatus support the following goal clerk send flags:

      --argb64 strings              base64 encoded args to pass to transaction logic
  -F, --from-program string         Program source to use as account logic
  -P, --from-program-bytes string   Program binary to use as account logic
  -L, --logic-sig string            LogicSig to apply to transaction
      --msig-params string          Multisig preimage parameters - [threshold] [Address 1] [Address 2] ...

Additional context

None.

Urgency/Relative Priority This is more of a nice-to-have at this point. Unless we get some really defined use cases, this will probably be low priority. That being said, we can move this up whenever the urgency increases.

yaovi-a commented 3 years ago

Need to confirm the significance of this. A.I. PM