Reevaluate fee threshold check in transaction pool

algorand / go-algorand

Algorand's official implementation in Go.

https://developer.algorand.org/

Other

1.35k stars 474 forks source link

Open tolikzinovyev opened 3 years ago

tolikzinovyev commented 3 years ago

Since the fee threshold check is per transaction, not transaction group, it does not work optimally when fees are distributed unevenly among participants in a transaction group. https://github.com/algorand/go-algorand/blob/80bd5ed6182baa1b54de065006f67c3358c65537/data/pools/transactionPool.go#L326

jannotti commented 3 years ago

Good find. This should have been addressed when we did fee pooling. My mistake. scytale can take it off your hands if you'd like.

Fortunately, since it is in the transaction pool, I don't think we need a consensus update to fix/change this.

tolikzinovyev commented 3 years ago

Feel free to fix it! No, a consensus upgrade shouldn't be needed.