Closed algoidurovic closed 1 year ago
Looks good. There are a number of minor suggestions that I don't feel strongly about. In particular of note:
- a suggestion to remove a print statement
- removal of
Account()
info from pre-existing test that doesn't need it- suggested assertion about the error message received in the case that app account for inner txn call wasn't funded
Also, I just realized that I still have the outstanding suggestion to create a new type alias DryRunAccountType = Union[str, Account]
Closing in favor of #33
For certain use cases, it's necessary to set the balance of the app account to some nonzero value. One example is testing inner app calls. This PR allows the users to set balances for accounts and updates the existing dryrun
cost
field (which is now deprecated) and adds support for the new cost fieldsBudgetAdded
andBudgetConsumed
.Testing: Unit tests.