algorand / graviton

🧑‍🔬 verify your TEAL program by experiment and observation
MIT License
17 stars 8 forks source link

Tech Debt PR Including Release Version Bump #42

Closed tzaffi closed 1 year ago

tzaffi commented 1 year ago

Removing:

Deprecated Mixins Originally Inherited from py-algorand-sdk

image

With cost no longer coming back, and the soon-coming need to support simulate, remove the deprecated dry run mixins. It's not worth continuing to support now that we get this error:

image

Orphaned methods and functions removed in graviton/dryrun.py:

Invariant.inputs_and_invariants()

This overly-complex method was guilty of causing a test to provide false confidence with never being run for 8 months. It already was slated for removal with a TODO:. So this is a good opportunity to remove.

Refactoring Dry Run Execution Methods

Removing parameters

Adding parameters

TODO

40 was NOT tackled here. However, the refactoring work here paves the way to address it and #44 is a child PR which addresses.