Deprecated Mixins Originally Inherited from py-algorand-sdk
With cost no longer coming back, and the soon-coming need to support simulate, remove the deprecated dry run mixins. It's not worth continuing to support now that we get this error:
Orphaned methods and functions removed in graviton/dryrun.py:
_fail()
assert_pass()
assert_reject()
assert_status()
assert_global_state_contains()
assert_local_state_contains()
DryRunHelper.guess()
DryRunHelper.format_stack()
DryRunHelper.find_delta_value()
DryRunHelper.save_dryrun_request()
Invariant.inputs_and_invariants()
This overly-complex method was guilty of causing a test to provide false confidence with never being run for 8 months. It already was slated for removal with a TODO:. So this is a good opportunity to remove.
Refactoring Dry Run Execution Methods
Removing parameters
abi_argument_types
abi_return_type
Adding parameters
abi_method_signature: str
omit_method_selector: bool
validation: bool
TODO
40 was NOT tackled here. However, the refactoring work here paves the way to address it and #44 is a child PR which addresses.
[x] The answer is "NO": ~Shall #44 be merged into this PR?~
Removing:
Deprecated Mixins Originally Inherited from
py-algorand-sdk
With cost no longer coming back, and the soon-coming need to support simulate, remove the deprecated dry run mixins. It's not worth continuing to support now that we get this error:
Orphaned methods and functions removed in
graviton/dryrun.py
:_fail()
assert_pass()
assert_reject()
assert_status()
assert_global_state_contains()
assert_local_state_contains()
DryRunHelper.guess()
DryRunHelper.format_stack()
DryRunHelper.find_delta_value()
DryRunHelper.save_dryrun_request()
Invariant.inputs_and_invariants()
This overly-complex method was guilty of causing a test to provide false confidence with never being run for 8 months. It already was slated for removal with a
TODO:
. So this is a good opportunity to remove.Refactoring Dry Run Execution Methods
Removing parameters
abi_argument_types
abi_return_type
Adding parameters
abi_method_signature: str
omit_method_selector: bool
validation: bool
TODO
40 was NOT tackled here. However, the refactoring work here paves the way to address it and #44 is a child PR which addresses.