The diff in graviton/blackbox.py is difficult to read through. Instead of looking at the diff, I encourage looking at the actual code. Additionally, this is a testing library, and therefore (IMO) we can gain most of the confidence by looking at the test results both here and in the companion pyteal PR.
Former PR
44
Issues Addressed
38
40
Summary of changes
graviton/blackbox.py:
Introducing class DryRunTransactionParams for better grouping of some variables
Trimming stale comments
class DryRunExecutor:
Removed all the static dryrun_* methods and consolidated functionality as follows:
It is now expected that the user will instantiate a DryRunExecutor object and call run() on it. Convenience methods run_one() and run_sequence() are also provided, and these have better type guarantees.
*_test.py and quadratic_factoring_game.ipynb - Migrating all the tests to use run_one() and run_sequence() methods (except for the usage of AbiContractExecutor.dry_run_on_sequence() which remains unaffected)
Adding unit tests in tests/unit/encode_test.py
test_executor_init
test_executor_prep
TODO's
[x] Address @michaeldiamant comments in #42 concerning an untested pathway and a suggested patch. This has been addressed here: 96a5e288a099d9805152691498c12bdb8af6c981
The diff in
graviton/blackbox.pyis difficult to read through. Instead of looking at the diff, I encourage looking at the actual code. Additionally, this is a testing library, and therefore (IMO) we can gain most of the confidence by looking at the test results both here and in the companion pyteal PR.Former PR
44
Issues Addressed
38
40
Summary of changes
graviton/blackbox.py:class DryRunTransactionParamsfor better grouping of some variablesclass DryRunExecutor:dryrun_*methods and consolidated functionality as follows:DryRunExecutorobject and callrun()on it. Convenience methodsrun_one()andrun_sequence()are also provided, and these have better type guarantees.*_test.pyandquadratic_factoring_game.ipynb- Migrating all the tests to userun_one()andrun_sequence()methods (except for the usage ofAbiContractExecutor.dry_run_on_sequence()which remains unaffected)tests/unit/encode_test.pytest_executor_inittest_executor_prepTODO's