Closed algorandskiy closed 2 months ago
Attention: Patch coverage is 33.33333%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 68.43%. Comparing base (
4bd144f
) to head (10f7c28
). Report is 34 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
idb/postgres/internal/writer/writer.go | 33.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@algorandskiy I suggest we ice box/close this for now - the driver for why the work was done may be resolved through configuration
Summary
Writer does not call Close (and so that DEALLOCATE) if some of statements fail in the middle. Although go's pg driver's
Prepare
is has map of prepared statements to prevent such errors (see the code excerpt below) it looks more correct to clean up in case of an error.Test Plan
No test, it is hard/impossible to test b/c driver's
Prepare
caches statements.