algorand / java-algorand-sdk

Algorand SDK for Java7+ to interact with the Algorand network
https://algorand.github.io/java-algorand-sdk/
MIT License
68 stars 69 forks source link

Fixes on Account and Transaction #714

Closed FabioRagno closed 5 months ago

FabioRagno commented 5 months ago

Pull request includes two fixes:

  1. min-balance attribute added in order to align sdk Account model to the ReST API response
  2. removing Transaction.fee initialization at 1000 microAlgos in case of null variable. Fix is necessary for response deserialization in case of transaction submitted with no fees, in particular in case of Atomic Transaction pooled fees. In case of single transaction, if no fee is set, the transaction will be rejected by the chain.
CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


fabio.ragno seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

gmalouf commented 5 months ago

@FabioRagno we are closing this specific PR:

Thank you for your contributions!