The ONLY change here is for the job to to run nightly @ 17:10 UTC, now that I have confidence that it's triggering correctly.
When will this be merged?
I'm hoping to merge AFTER I see that the nightly build is actually respecting the requirement that the heavy portion of the job NOT run after 24 hours of no commits.
How to remove if we end up ditching the nightly job?
Originally, I was envisioning reverting all the commits. However, there have been permanent changes that I'm planning to keep.
remove .github/workflows/nightly.yml
remove the check-code-changes and nightly-slow targets introduced to the Makefile
What are the permanent changes?
upgrading the github setup-python action to v4
making the Makefile commands in the workflow, as succint as possible. I.e. introducing the following Makefile targets:
algod-integration for integration tests setup and running
I'm proposing that changes to the Makefile be made permanent (except possibly for the nightly-slow and check-code-changes targets), as well as to .github/workflows/build.yml (no exceptions).
This PR provides an opportunity for anyone to comment on these permanent changes (and anything else).
What's the difference between a HEAVY nightly build job, and a light one?
The first job took around 4 minutes to run while the second job took less than 1 minute. That's because the last commit into master had occurred between 10:10 and 11:10 the day prior 2/15/2022.
bbroder-algo
commented
1 year ago
What's the change?
The ONLY change here is for the job to to run nightly @ 17:10 UTC, now that I have confidence that it's triggering correctly.
When will this be merged?
I'm hoping to merge AFTER I see that the nightly build is actually respecting the requirement that the heavy portion of the job NOT run after 24 hours of no commits.
How to remove if we end up ditching the nightly job?
Originally, I was envisioning reverting all the commits. However, there have been permanent changes that I'm planning to keep.
.github/workflows/nightly.ymlcheck-code-changesandnightly-slowtargets introduced to theMakefileWhat are the permanent changes?
setup-pythonaction tov4Makefilecommands in the workflow, as succint as possible. I.e. introducing the followingMakefiletargets:algod-integrationfor integration tests setup and runningsetup-build-testfor unit tests setup and runningWhat feedback is being reqeusted?
Please have a look at this diff: https://github.com/algorand/pyteal/compare/v0.23.0...master
I'm proposing that changes to the
Makefilebe made permanent (except possibly for thenightly-slowandcheck-code-changestargets), as well as to.github/workflows/build.yml(no exceptions).This PR provides an opportunity for anyone to comment on these permanent changes (and anything else).
What's the difference between a HEAVY nightly build job, and a light one?
Compare the following 2 jobs:
The first job took around 4 minutes to run while the second job took less than 1 minute. That's because the last commit into
masterhad occurred between 10:10 and 11:10 the day prior 2/15/2022.