algorand / pyteal

Algorand Smart Contracts in Python
https://pyteal.readthedocs.io
MIT License
285 stars 131 forks source link

Validation Already Happens in Compiler - Remove from Router #690

Closed tzaffi closed 1 year ago

tzaffi commented 1 year ago

Reasoning

The following call-trace shows validation already happenend in compiler.py by the time that the code running validation in the router runs again. Given the instability of compilation (#199 ), and to avoid unnecessary CPU cycles - we should remove the second validation.

Call Trace that Proves Validation