search

algorandfoundation / algokit-lora

https://lora.algokit.io
12 stars 5 forks source link

Transaction visualiser amount rounding #238 #243

Closed satishccy closed 2 months ago

satishccy commented 2 months ago

I have changed the line in https://github.com/algorandfoundation/algokit-lora/blob/main/src/utils/compact-amount.ts#L4 from 8 to 9.

First i have tested out the scenario by making a transaction http://localhost:1420/testnet/transaction/HZXSLRMSVSHXYH3VILN62EFLZD6Y3XNOQPDTJ2QGJV73IJLI3U4Q as which was discussed in discord https://discord.com/channels/491256308461207573/1277185471214256138 and got below visual image which looks good & all 6 digits are visible.

Previous Snapshot - transactions-visual (8) Updated Snapshot - transaction-HZXSLRMSVSHXYH3VILN62EFLZD6Y3XNOQPDTJ2QGJV73IJLI3U4Q

I have ran the tests & got 3 errors in the following transactions due to snapshot mismatch

  1. http://localhost:1420/mainnet/transaction/WYEGSIGWZHTR6VYXC3EXFGZQHYKI6FQOZU2DOKHQCAWYEIHJBKEA -

Previous Snapshot - transactions-visual (5) Updated Snapshot - transaction-WYEGSIGWZHTR6VYXC3EXFGZQHYKI6FQOZU2DOKHQCAWYEIHJBKEA

  1. http://localhost:1420/mainnet/transaction/INDQXWQXHF22SO45EZY7V6FFNI6WUD5FHRVDV6NCU6HD424BJGGA -

Previous Snapshot - transactions-visual (6) Updated Snapshot - transaction-INDQXWQXHF22SO45EZY7V6FFNI6WUD5FHRVDV6NCU6HD424BJGGA

  1. http://localhost:1420/mainnet/block/36591812/group/%2FoRSr2uMFemQhwQliJO18b64Nl1QIkjA39ZszRCeSCI%3D -

Previous Snapshot - transactions-visual (7) Updated Snapshot - round-36591812-group-_oRSr2uMFemQhwQliJO18b64Nl1QIkjA39ZszRCeSCI=

I have reviewed the above 3 updated snapshots and they are visually looking good & showing upto 6 decimals. So i have updated the snapshots.

But even after updating the code, we are unable to show 6 decimals if the whole number is greater than 9, as you can see the in below scenario i have made payment transaction of amount 12.000115 algos and visual image is not showing 6 decimals. http://localhost:1420/testnet/transaction/ZZGHI5HFGRXCSNGY5RMPZHIAJF5G5E5NJXLQ7T6OAIIU6XBKOREQ

image