search

algorandfoundation / algokit-python-template

Official AlgoKit template for smart contract development project using Algorand Python
6 stars 3 forks source link

Minor pre-commit and lint action inconsistencies #27

Closed cusma closed 4 months ago

cusma commented 4 months ago

Subject of the issue

There is a minor discrepancy on linter when executed as pre-commit run -a and algokit project run lint.

Also:

  1. In .algokit.toml replace 'poetry run ruff .' (deprecated) with 'poetry run ruff check .'
  2. In .algokit.toml replace 'poetry run mypy ' with 'poetry run mypy . '

Steps to reproduce

  1. Init new project with algokit init
  2. Build artifact with algokit project run build
  3. Run linter with pre-commit run -a

Expected behaviour

Linter has no errors if run right after a project init.

Actual behavior

Lint errors in hello_world_test.py

Warning: --strict-concatenate is deprecated; use --extra-checks instead
error: Expression has type "Any"  [misc]
error: Expression has type "Any"  [misc]
error: Expression type contains "Any" (has type "dict[str, Any]")  [misc]
error: Expression has type "Any"  [misc]