search

algorandfoundation / algokit-python-template

Official AlgoKit template for smart contract development project using Algorand Python
6 stars 3 forks source link

Template should avoid the --project-name argument in CI/CD definitions for non-workspace projects. #57

Closed CiottiGiorgio closed 1 month ago

CiottiGiorgio commented 3 months ago

With this recent AlgoKit PR, the --project-name argument on the CI/CD jobs will be proxied to the underlying script execution causing most run config to fail.

For templates that are not rendered in a workspace type, that argument should not be included.

CiottiGiorgio commented 3 months ago

This also probably means that the fullstack template should be changed accordingly to add back the --project-name arg.

aorumbayev commented 1 month ago

@CiottiGiorgio the PR you outlined should only pass the arguments separated with --. --project-name is still a dedicated option registered on run tasks in cli. Can you showcase a reproducible example that passes project name down to task? I wasn't able to replicate by running algokit deploy testnet --project-name 'production_python' on examples. It correctly picked up the production_python name based on behaviour of the registered option rather then forwarding that arg to the underlying python invocation

CiottiGiorgio commented 1 month ago

I couldn't find the bug that prompted this issue and I couldn't reproduce now. I agree that the expected behavior is in place with a non-workspace project and the CI/CD pipeline though.

We can close this.