algorandfoundation / algokit-python-template

Official AlgoKit template for smart contract development project using Algorand Python
6 stars 3 forks source link

Revert test template to create rather than deploy #8

Open CiottiGiorgio opened 6 months ago

CiottiGiorgio commented 6 months ago

I've noticed the switch from .create() to

client.deploy(
    on_schema_break=algokit_utils.OnSchemaBreak.AppendApp,
    on_update=algokit_utils.OnUpdate.AppendApp,
)
return client

Personally I am used to and I see .create() more fit in the context of unit testing. What was the reason for this change? I'm asking because I've been bit by instances where I'm only changing the test (and not the contract) and I was getting wrong results because of initial funding and/or previous state/boxes in the previous deployment.

robdmoore commented 5 months ago

@aorumbayev can you weigh in here please?