algorandfoundation / liquid-auth

Liquid Auth Service

http://liquidauth.com/

Apache License 2.0

21 stars 6 forks source link

Feat/fido connect extension #13

Closed PhearZero closed 4 months ago

PhearZero commented 4 months ago

ℹ Overview

This PR includes all of the testing updates and the FIDO Connect Extension

Replaces Connect Controller with Signal Controller
Moves Connect Attestation to FIDO2 Attestation with Liquid Extension

Android Client: https://github.com/awesome-algorand/android-authentication-client/releases/tag/v0.2.0

📝 Related Issues

Related PRs

supersedes #4
supersedes #5
supersedes #6
supersedes #9

✅ Acceptance:

[x] Conventional Commits
[x] npm run test:cov passes

HashMapsData2Value commented 4 months ago

I noticed when running npm run test:cov locally - and after double-checking in the CI jobs - that 6 tests are skipped and that there's an error with Nest

[Nest] 2003 - 04/25/2024, 1:32:43 AM ERROR [AttestationController] Not Found Exception

Is there a reason for this?

PhearZero commented 4 months ago

I noticed when running npm run test:cov locally - and after double-checking in the CI jobs - that 6 tests are skipped and that there's an error with Nest

[Nest] 2003 - 04/25/2024, 1:32:43 AM ERROR [AttestationController] Not Found Exception

Is there a reason for this?

@HashMapsData2Value A few tests are skipped, still working on getting coverage up. We are testing error conditions for better branch coverage and this is the source of the Nest errors