search

algorithm-archivists / algorithm-archive

A collaborative book on algorithms
https://www.algorithm-archive.org
MIT License
2.33k stars 353 forks source link

Create euclid.js #1000

Closed elfaidi-ghassen closed 2 years ago

Amaras commented 2 years ago

Hi! Thank you for your first PR to the Algorithm Archive. I am afraid we cannot consider your PR, as there already is a Euclidean algorithm JS implementation, and you didn't explicitly aim to improve it. Furthermore, implementations files should be in the directory named after the language, so putting JavaScript code in the Factor directory is not the structure we are looking for.

For all these reasons, I have to close this PR immediately without review. I hope you'll still want to improve the AAA further :)