search

algorithm-archivists / algorithm-archive

A collaborative book on algorithms
https://www.algorithm-archive.org
MIT License
2.33k stars 353 forks source link

Convolutions in 1d in rust #1007

Open eengamer2007 opened 1 year ago

eengamer2007 commented 1 year ago

implemented the convolutions 1d in rust

eengamer2007 commented 1 year ago

i saw somewhere that I should add my name to the contributers list since this is my first contribution. Should that be in this pull request?

leios commented 1 year ago

Yeah, add that to this pr, if you can

Amaras commented 1 year ago

Oof, sorry for the delay in the response.

So, the main problem with your PR currently is that the line numbers don't track correctly. I don't see a reason to refuse your code in the AAA now, so please make sure the lines you include your code at are indeed the correct ones before I merge them.

eengamer2007 commented 1 year ago

sorry for the late fix, school was keeping me busy.