algorithm-archivists / algorithm-archive

A collaborative book on algorithms
https://www.algorithm-archive.org
MIT License
2.33k stars 353 forks source link

Implementing Stack and Queue in Kotlin #1017

Closed rdugue closed 9 months ago

rdugue commented 9 months ago

name: Code submission about: Add code or modify existing code in the Algorithm Archive

Code submission

Description

These are implementations of the stack ad queue data structures in Kotlin. I did both since they are fairly simple and this is one section in the book, even though the guideline say to do one algorithm at a time. If that is an issue I am more than happy to split them up into separate pull requests.

For Algorithm Archive Developers

Amaras commented 9 months ago

Hi! Thank you for the PR and your interest for the AAA. Unfortunately, we generally don't accept PRs from main branches, as they are bound to cause problems on merge, either for you or us.

The guideline indeed say to only implement one algorithm at a time, although it should say to only implement one chapter, so your PR is admissible on this count, don't worry.

I'm going to approve the CI run and we'll see if it compiles. In any case, I'd rather you opened a PR from the "stacks and queues" branch you seem to be using to develop. Please just wait until the CI run is over before closing this PR, just so we're sure your code compiles (assuming we have Kotlin installed on that environment)

Amaras commented 9 months ago

We don't have Kotlin installed on the CI environment, so... we'll have to do it manually.

I'll close this PR, please open a new PR from your development branch, and not your main.