algorithm-archivists / algorithm-archive

A collaborative book on algorithms
https://www.algorithm-archive.org
MIT License
2.38k stars 356 forks source link

Suggestion: Add github CLI inside Docker #970

Closed ShadowMitia closed 2 years ago

ShadowMitia commented 2 years ago

I was thinking we could maybe add the Github CLI tool, not particular reason other than have it as a commodity for people using Docker.

It would make testing PRs a bit easier, because you can just go and grab the command directly from Github:

image

I don't really use the tool for anything else myself, but maybe there are other uses to simplify git/github interaction?

Amaras commented 2 years ago

I use the official CLI myself (outside of Docker containers), and I can tell you that it's way easier to switch between PRs.

However, if we modify the Docker configuration, it requires to build the image locally, and I don't think there is an extension to do that. (EDIT: Not useful)

ShadowMitia commented 2 years ago

As pointed out by @Amaras on Discord, gh requires authentication/token to allow to be used correctly. Even with the gh pr one, which is annoying... Still could be useful, but much less practical right now.

Amaras commented 2 years ago

Closing this for now