search

algorithm-visualizer / tracers.js

:scroll:Visualization Library for JavaScript
https://algorithm-visualizer.org/
MIT License
63 stars 28 forks source link

Incorrect type for LogTracer functions? #6

Open MarkKoz opened 5 years ago

MarkKoz commented 5 years ago

LogTracer.set()'s parameter has a type of string but the print functions use any. All functions seem to have the same general purpose: to log the argument given Well, which type is it then? Is set() really meant to have a different type than the rest?

64json commented 5 years ago

I designed that way so that LogTracer.set() directly sets the string value that will be displayed whereas the print functions convert the value to string and then append it to the displayed value. However, I agree that LogTracer.set() should also convert any value to string first before setting it in order to not confuse users. You can make LogTracer.set() in tracers.py have any parameter. I'll fix it in tracers.js and algorithm-visualizer.