DEV-297 - Updated integration tests to be more automatic given env variables

algorithmiaio / algorithmia-nodejs

Algorithmia node.js client library

39 stars 8 forks source link

DEV-297 - Updated integration tests to be more automatic given env variables #28

Closed acanedo closed 3 years ago

acanedo commented 3 years ago

Added dotenv package to be able to use .env file in root directory.
Added TEST.md explaining how to set environment variables for testing.
Modified integration tests to use environment variables to an specific algorithmia account and api address.
Added three more methods to AlgorithmiaClient.ts to be able to build and publish algorithms and delete organization. This helps automate all tests without having to do preloading of data within an account.
Added lint-fix npm script to also handle and clean the test files.
Renamed some testing files and static content to have more meaning.
Created a TestUtils.ts file to keep reusable code needed for all the test suites.

acanedo commented 3 years ago

@warmbowski Was going through this and realized I had a bug. Would you mind re-approving/re-reviewing.

acanedo commented 3 years ago

@warmbowski So I did some investigating and I found

DELETE /v1/organizations/:orgName @controllers.v1.Organizations.deleteOrganization(orgName: String)

but DIDN'T work :(. Or it behaves strangely.

So I'm not sure if the endpoint actually just does a soft delete on an organization.

But if I run a delete by org_name and then try and run a getOrganization then it tells me there's no org by that name. That seems correct.

The problem is that if I try and create a new org with the same org_name (as the one previously deleted) then the response tells me the org_name is already taken. Which doesn't seem right given I deleted the organization already. I'm not sure if this intended by design?

Anyways, I also fixed the bogus emails to have @example.com and left the organization tests to NOT delete instead.

warmbowski commented 3 years ago

The problem is that if I try and create a new org with the same org_name (as the one previously deleted) then the response tells me the org_name is already taken. Which doesn't seem right given I deleted the organization already. I'm not sure if this intended by design?

From what I have heard, this is by design.

acanedo commented 3 years ago

pushed new changes, it now soft deletes orgs.