Closed danielfrg closed 3 years ago
Good find, so that's an interesting piece as we have the "New Developer Experience" system that exists here( https://github.com/algorithmiaio/algorithmia-python/blob/master/Algorithmia/handler.py) that Anaconda environments use, but vanilla pypi python does not - however that's not due to a technical limitation but rather product weigh-in. The pipe
operation is a little different here, but https://github.com/algorithmiaio/langpacks/blob/2b0ac88804aaca2fae04d07f2f9f1149225b4ba4/libraries/anaconda3-runtime/context/pipe defines what that script would look like; as you can see it's simply excuting the algorithm primary file as an executable.
yeah, i kinda decided to keep it in the "old" way of doing thing mostly for consistency with the python3 langpack.
Do you prefer to make the anaconda one use the new dev experience? I was thinking that when we update the regular python envs and templates we could also update the anaconda one.
I dont have strong opinions and we could start pushing that with the anaconda envs.
I think i was also trying to make the anaconda one use the same as pipe as python3 so updating one would update the other but i dont think i like that idea anymore...
OK, I updated it so we can start pushing the new dev experience :D
@zeryx or @kennydaniel could one of you do a final review? i made the changes we talked yesterday.
Thanks!
I saw the file was missing while testing the new language on the test environment.
I think this type of errors are hidden from the validator script because of how we handle the docker context here.
Test with: