algorithmiaio / langpacks

Standardized builder and runners for Algorithmia algorithms
https://algorithmia.com/
MIT License
16 stars 9 forks source link

ALGO-943 initial python3-adk release #191

Closed zeryx closed 3 years ago

zeryx commented 3 years ago

ALGO-943 - Ship python ADK This PR adds a new "language" for python (which preserves backwards compatibility with the old IPA system for python) that will provide a whole suite of new features and functionality. For more information please check out the ADK repo itself: https://github.com/algorithmiaio/algorithmia-adk-python Unit tests and integration tests have been added to the algorithmia-adk-python repo and CI gates release.

To test this, please run the following with the validator: ./tools/environment_validator.py -g python3-adk -s python37 -t language -n python3-adk -c 1 and test with curl localhost:9999 -H 'Content-Type: application/json' -d '{"name": "Anthony"}' If that returns successfully, then the test has passed.

Checklist

kennydaniel commented 3 years ago

Overall looks good with some minor comments. The load function missing was a big part of the goal with ADK i thought? Also the name is a bit long "Python 3.x (Environments) - Algorithm Development Kit". I think languages don't generally include "(Environments)"?

We can merge in langpacks, but we should hold deploying the environment until docs are ready. The ADK readme is solid, I think that mostly would need to be added to devcenter.