Add timbre

[tkell]

This change is

[bmcfee]

Reviewed 2 of 4 files at r1. Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

---

amen/audio.py, line 204 at r1 (raw file):

    def _get_timbre(self):
        """

Docstrings needed

---

_amen/echo_nest_converter.py, line 135 at r1 (raw file):_

                # we take the first 12 mfccs
                timbre_dimensions = range(12)
                value = [value[t] for t in timbre_dimensions]

I think you can just do value = list(value) here? Assuming value has 12 dimensions to begin with.

---

Comments from Reviewable

[tkell]

Review status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.

---

amen/audio.py, line 204 at r1 (raw file):

Previously, bmcfee (Brian McFee) wrote…

> Docstrings needed >

...docstring is at line 205?

---

_amen/echo_nest_converter.py, line 135 at r1 (raw file):_

Previously, bmcfee (Brian McFee) wrote…

> I think you can just do `value = list(value)` here? Assuming `value` has 12 dimensions to begin with. >

value is a dict with 20 elements in it, hence why I am doing the goofy thing above.

(how do I submit a comment on this website)

---

Comments from Reviewable

[tkell]

Paging @bmcfee to see how you feel about having the keys to the timbre feature be mfcc_0, mfcc_1, etc.