algorithmsbooks / decisionmaking

Algorithms for Decision Making textbook
522 stars 54 forks source link

Mutating function notation #70

Closed johannes-fischer closed 3 years ago

johannes-fischer commented 3 years ago

gibbs_sample and update_gibbs_sample in algorithm 3.10 mutate the argument a. So maybe it would be clearer to call them gibbs_sample! and update_gibbs_sample!, according to julia convention of functions mutating their arguments. Possibly also removing the explicit assignment a=gibbs_sample(...).

mykelk commented 3 years ago

Fixed and reposted. Thanks!