search

algorithmsbooks / optimization

Errata for Algorithms for Optimization book
68 stars 16 forks source link

rand_positive_spanning_set #33

Closed mykelk closed 4 years ago

mykelk commented 4 years ago

Alg. 8.2 seems to have an issue with the construction of D. There seems to be some no-ops going on here:

D = L[randperm(n),:]
D = L[:,randperm(n)]
zsunberg commented 4 years ago

Were you expecting D to be a view of L? The current behavior is to make a copy, but I think some version long ago it acted like a view

(Sent from phone)

On Fri, May 8, 2020, 22:05 Mykel Kochenderfer notifications@github.com wrote:

Alg. 8.2 seems to have an issue with the construction of D. There seems to be some no-ops going on here:

D = L[randperm(n),:] D = L[:,randperm(n)]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sisl/algforopt-errata/issues/33, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABALI23IIDCYXPV44TCYOETRQTJA5ANCNFSM4M4UAVKQ .

mykelk commented 4 years ago

Even so, shouldn't the second line have a D on the right hand side?

tawheeler commented 4 years ago

Right. That's an easy fix.