search

algorithmsbooks / optimization

Errata for Algorithms for Optimization book
67 stars 16 forks source link

Descriptions of Algorithms / Comments in Algorithms #60

Closed chelseas closed 2 years ago

chelseas commented 2 years ago

I am opening another issue because students have been coming to me in office hours with confusion over the Julia code for the algorithms and requests for pseudo-code explanations. Here I am including for your consideration the marked up algorithm examples, versions of which I have sent to students to explain what is going on. trust_region 1.pdf

algo_9.6_revision.pdf

This is not an algo description but what I think would be a more clear and precise description of the algorithm: algo textbook pg 151_revisions.pdf

tawheeler commented 2 years ago

We can certainly make some of these changes, like making symbols consistent with the text. If the comments fit we can probably add them.

tawheeler commented 2 years ago

Committed most of the changes from trust_region1.pdf

tawheeler commented 2 years ago

Committed many changes for alg 9.6

tawheeler commented 2 years ago

I'm not going to take the suggestion for the last pdf, as it will affect pagination. Also, whether it is uniformly at random or not is not really the point. Yes, we implement it to be uniform, but you don't have to.

mykelk commented 2 years ago

Posted to the book site. Thanks!

chelseas commented 2 years ago

Re: the last one ("uniformly at random"), I raised that point specifically because a student was confused. To say the samples are "chosen from the top k" is vague. You don't have to say "uniformly" at random, but I would change it to say "chosen at random" at least. Also you might want to include in the comments for the implementation of that algo that you implement it choosing "uniformly at random."

tawheeler commented 2 years ago

"chosen at random" does not fit on the page without more work.

I thought about it overnight and changed "choose" to "sample".

mykelk commented 2 years ago

Sounds good to me! Thanks Tim and Chelsea!