search

algorys / gitlabproject

Dokuwiki plugin to display a Gitlab project
3 stars 4 forks source link

link to image is broken #2

Closed Finkregh closed 7 years ago

Finkregh commented 7 years ago

the link to the gitlab-logo is broken, as it uses a relative link:

<img src="lib/plugins/gitlabproject/images/gitlab.png" class="gitlab">
algorys commented 7 years ago

Ok, I'll have a look ASAP

algorys commented 7 years ago

Strange, because normally this link should be work...

When you try to reach http://WIKI_URL/lib/plugins/gitlabproject/images/gitlab.png, image is not displayed ?

Because, it's working very well on my test server and for other plugins. Check you have gitlab.png in gitlab plugin folder also.

Finkregh commented 7 years ago

yep, but when i open /some/other/page then i get a relative link to 'lib/plugins/...'

algorys commented 7 years ago

@Finkregh Sorry, but I don't undestand what you say with /some/other/page ? Have you a screenshot please to understand your problem ?

Finkregh commented 7 years ago

no problem ;-)

i open the wiki page via https://wiki/playground/playground. the image there is linked via src="lib/plugins/... and it should be linked via src="https://wiki/lib/plugins/...

algorys commented 7 years ago

Yes but normally Dokuwiki add the rest of url alone.... maybe it's due to https.

I'll try to find a way to add Wiki url to this link.

@Finkregh when you open deleoper tools in your browser and you hover the link, what url you have ?

algorys commented 7 years ago

@Finkregh last version should solve your problem :wink:

Finkregh commented 7 years ago

yes, but i cant update via the DW gui because you changed things in the devel-branch...

algorys commented 7 years ago

@Finkregh oups sorry, I merge right now.

Edit: you can now update plugin.

Finkregh commented 7 years ago

in line 153 is another image-link :-)

algorys commented 7 years ago

Sorry, I forget this case. Done.