algosup / 2023-2024-project-4-sportshield-team-8

9 stars 0 forks source link

Functional Specifications: First Review #12

Closed Biohazardyee closed 8 months ago

Biohazardyee commented 8 months ago

Description

After a first quick review of the document, I noticed some stuff that are contradictory to what we have decided as a team, as much as some mistakes in the document.

About the project scope: I think that the part about the battery being the most important doesn't have a slot here, as every requirements are quite important. You should try to rephrase that.

Budget: I have made a grammar mistake, we should remove "via" for example.

For the Georges Michael personna: We said that we will remove the GPS, however, George wants to locate his skis, he won't be able to do so with our final product, this part should be removed in my opinion.

I noticed various English mistakes in the bio of the personnas, please re-do them while using a Grammarly, it would improve the overall quality of the document.

Test case used

No response

Severity

2 - High

Testing environment

Operating system: Windows Other: GitHub document

Steps taken

No response

Expected result

No response

Actual result

No response

Potential solution

No response

Other

I'll reopen issues as the document evolves, come back to check regularly to check whether there are new issues.

Victor-Leroy commented 8 months ago

Appreciate the review @Biohazardyee, in your opinion, what should the ski location be modified with?

Biohazardyee commented 8 months ago

I think that something about the battery consumption could be interesting.

MaximeTAlgosup commented 8 months ago

Here is the modification to the Project scope, is it better?

Screenshot 2024-03-15 162812

We decided to not change the "via". We corrected the personas.

Biohazardyee commented 8 months ago

The project scope seems right to me now.

I really think the "via" is not right there, we'll discuss this together.

Personnas seem right to me as well.