alhappler / alh_pdf_view

12 stars 8 forks source link

Gradle plugin update required #51

Open Harishwarrior opened 2 weeks ago

Harishwarrior commented 2 weeks ago

When using with flutter project that has target sdk as 34. The gradle build throws an warning. We may need to update the gradle plugin to 8.x

We recommend using a newer Android Gradle plugin to use compileSdk = 34

This Android Gradle plugin (7.4.2) was tested up to compileSdk = 33

This warning can be suppressed by adding
    android.suppressUnsupportedCompileSdk=34
to this project's gradle.properties

The build will continue, but you are strongly encouraged to update your project to
use a newer Android Gradle Plugin that has been tested with compileSdk = 34
Update Gradle property to suppress warning
Affected Modules: alh_pdf_view_android
andreBalh commented 2 weeks ago

Hello @Harishwarrior Which version do you use of this package? Probably you have to update to the version 2.0.0 because the newest version runs also on 34. And if this isn't fixing your issue, can you send me the report of flutter doctor -v?

There was also a very similar issue here #50

Harishwarrior commented 2 weeks ago

We recommend using a newer Android Gradle plugin to use compileSdk = 34

We recommend using a newer Android Gradle plugin to use compileSdk = 34

As the error says we need to update grade plugin to 8.0x currently it is 7.x to be compatible with compile sdk 34

andreBalh commented 2 weeks ago

Can you send me the report of flutter doctor -v? @Harishwarrior

andreBalh commented 2 weeks ago

I tried this with the example app (using flutter run --release and flutter run --profile) and cannot reproduce the issue. Did you try flutter pub upgrade? Probably the app is still running with an older version. @Harishwarrior

Harishwarrior commented 2 weeks ago

Open the android folder in Android studio. Select Build -> Clean and then select Rebuild project.

My pubspec.lock file

  alh_pdf_view:
    dependency: "direct main"
    description:
      name: alh_pdf_view
      sha256: "120e340eb3c7102db9a9851ff0d739267c335f755c2296553fe9dc96cc5d0947"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.0"
  alh_pdf_view_android:
    dependency: transitive
    description:
      name: alh_pdf_view_android
      sha256: "56b4e0200a522ba4f7703e367bc05d9965ce1cf9c0478cffe6c86df34c1a9e94"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.0"
  alh_pdf_view_ios:
    dependency: transitive
    description:
      name: alh_pdf_view_ios
      sha256: b7f3bc94188536c350d9a7d3ecaf8d568d77dc6338dd647753bd1b69908fc63f
      url: "https://pub.dev"
    source: hosted
    version: "2.0.0"
  alh_pdf_view_platform_interface:
    dependency: transitive
    description:
      name: alh_pdf_view_platform_interface
      sha256: "44defb6a34e1243449f0ab7b1e3447d652bd25809bc6560a3289a03b56a1dde1"
      url: "https://pub.dev"
    source: hosted
    version: "2.0.0"
Harishwarrior commented 2 weeks ago

Flutter doctor output

[✓] Flutter (Channel stable, 3.19.6, on macOS 13.6.6 22G630 darwin-arm64, locale en-IN)
    • Flutter version 3.19.6 on channel stable at /Users/harish/fvm/versions/3.19.6
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (4 weeks ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/harish/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode-15.2.0.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (5 available)
    • SM P610 (mobile)  • 2c8976c991a9821b          • android-arm64  • Android 13 (API 33)
    • ipad4 (mobile) • 00008020-001D150036F3402E • ios            • iOS 17.2 21C62
    • iPad 5 (mobile)   • 00008030-000138293420202E • ios            • iOS 17.4.1 21E236
    • macOS (desktop)   • macos                     • darwin-arm64   • macOS 13.6.6 22G630 darwin-arm64
    • Chrome (web)      • chrome                    • web-javascript • Google Chrome 124.0.6367.207

[✓] Network resources
    • All expected network resources are available.
andreBalh commented 2 weeks ago

Hello, now I see the warning with the flutter version 3.16.9. I will check this after my holidays, if you are motivated, you can try to fix this warning, I am not sure if this is also in the stable version of flutter. @Harishwarrior