ali-alidoust / gta5-extended-video-export

GTA V Video Export Enhancement
Apache License 2.0
25 stars 18 forks source link

Fix fps hook failed, use nuget for dependencies, various fixes. #1

Closed mcmtroffaes closed 7 years ago

mcmtroffaes commented 7 years ago

I just wanted to compile the plugin to fix the "fps hook failed" issue, and whilst doing so I update a variety of things:

ali-alidoust commented 7 years ago

Wow that's lot's of good changes in the project. I would like to thank you for your contributions. I'm sorry that I couldn't merge your pull request earlier. I changed the project a lot in that patch, and since I was the only contributor I used this repo as some kind of stash. Now I will create a branch and add GPU motion blur to the mod. It's already done on my own PC, but requires some changes. I would like to add your name as a contributor to the project on the GTA5-Mods site. What's your ID there? I will update the mod page very soon. Again thank you for the changes.

mcmtroffaes commented 7 years ago

Many thanks for merging, for the trust, and for offering me to be named contributor - that's extremely kind of you, and deeply appreciated! I apologize that this pull request messes with your local changes.

The only thing I realize now is that this merge reverts also the shutter_position -> motion_blur_strength rename; so probably that part should be reapplied separately as otherwise users might be confused. Other than that, as far as I can tell, this should be pretty much release ready.

You can find me on gta5-mods as "mcmtroffaes".