search

ali-alidoust / gta5-extended-video-export

GTA V Video Export Enhancement
Apache License 2.0
25 stars 18 forks source link

Mod currently does not work #10

Open ali-alidoust opened 7 years ago

ali-alidoust commented 7 years ago

I noticed the mod doesn't export videos currently. I haven't had the chance to take a log file, but I'll attach one soon.

mcmtroffaes commented 7 years ago

I've had this problem intermittently as well (actually trying to fix this is the original reason that I started working on the code), but I never really managed to fix it completely (although https://github.com/ali-alidoust/gta5-extended-video-export/commit/ccb8667e8ebfa7fde2f7498b6d3802b05bf16869 helped). I don't know what is still causing the problem; restarting the game sometimes solves it. But I haven't yet tried the mod much since the latest update, will give it a fresh run this evening. Aside, are you using the build from appveyor? https://ci.appveyor.com/project/ali-alidoust/gta5-extended-video-export/build/artifacts

mcmtroffaes commented 7 years ago

Did you get anywhere with debugging the problem?

To get a better understanding of the fine details of your mod, I started writing a separate but much simpler implementation (not doing any of the fancy directx stuff, and only hooking into the media foundation, so limited to 1920x1080 with chroma subsampling via NV12 rather than a full resolution); it's functional now and the code is here:

https://github.com/mcmtroffaes/gta5-simple-video-export

Could I ask how you got the patterns to hook into GTA's own functions (e.g. for getting custom FPS support)?

https://github.com/ali-alidoust/gta5-extended-video-export/blob/master/gta5-extended-video-export/yara-patterns.h

The next best thing I can guess is that there might be a problem there.

ali-alidoust commented 7 years ago

I've had problems compiling the mod on my pc, so I didn't have any progress. That's great. I see you have written much much cleaner code. I somehow think this project has gone far from being refactorable. I use x64dbg and examine the assembly code to find these functions. The most problematic thing for me was that I couldn't set breakpoints since it would crash the game.

mcmtroffaes commented 7 years ago

I'm sorry to hear that you're having trouble compiling the mod... :-( Is it anything I can help with? In any case, thanks for the kind words about my code, and for pointing me to x64dbg. I've never used it, but I will give it a shot when I find enough time, and see if I can reproduce your findings.