search

ali-rezvani / onejar-maven-plugin

Maven onejar plugin
0 stars 0 forks source link

Dependencies in 'system' scope not included #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.  Add a dependency similar to the following:
        <dependency>
            <groupId>com.ibm</groupId>
            <artifactId>com.ibm.mq</artifactId>
            <version>7.0</version>
            <scope>system</scope>
            <systemPath>${lib.path}/com.ibm.mq.jar</systemPath>
        </dependency>
2. Make sure the <systemPath> points to a valid local directory & filename
3. Run mvn clean package

What is the expected output? What do you see instead?

Expected output is to have a xxx.one-jar.jar that includes all
dependencies.  Instead, I only see the dependencies included in the
xxx.one-jar.jar that do NOT have a 'system' scope.

What version of the product are you using? On what operating system?
1.4.0

Please provide any additional information below.
I've tried using the <binlibs> element in the plugin and specifying my
system dependencies.  That included the dependencies however, it packaged
them into a binlib directory, which was not what was desired.

Original issue reported on code.google.com by rod.bire...@gmail.com on 15 Apr 2009 at 5:29

GoogleCodeExporter commented 9 years ago

Original comment by hugo.josefson.old@gmail.com on 15 Apr 2009 at 7:53

GoogleCodeExporter commented 9 years ago 
Thank you Rod for the bug report!

I have fixed the issue, and deployed version 1.4.1-SNAPSHOT for you. Please 
test by
using <version>1.4.1-SNAPSHOT</version> of onejar-maven-plugin in your pom.

Let me know if it works for you, and then I'll release version 1.4.1 for 
everyone to
enjoy :)

/Hugo

Original comment by hugo.josefson.old@gmail.com on 15 Apr 2009 at 8:11

GoogleCodeExporter commented 9 years ago 
Hugo, I just tested <version>1.4.1-SNAPSHOT</version> and now the dependencies 
in a
'system' scope are included (as well as other dependencies).  Thanks!

Note:
The plugin appears to have a dependency on commons-logging and if all my 
dependencies
are 'system' scope then I have to add the commons-logging dependency.  However, 
in
the case of my project, I'm using spring 2.5.6 and if I remove the 'system' 
scope for
the spring dependency and have maven pull it from a repository I get a duplicate
exception...

java.util.zip.ZipException: duplicate entry: lib/commons-logging-1.1.1.jar
...

So, it's not an issue for me because I have to use 'system' scope for this 
project. 
I thought I'd just pass this along.

Thanks for the fast turnaround!

Original comment by rod.bire...@gmail.com on 16 Apr 2009 at 1:00

GoogleCodeExporter commented 9 years ago 
Good.

I have now deployed version 1.4.1 in the release maven repo, and updated usage
instructions to specify that version.

/Hugo

Original comment by hugo.josefson.old@gmail.com on 22 Apr 2009 at 8:16