ali-sdk / ali-ons

Aliyun Open Notification Service Client
MIT License
151 stars 43 forks source link

[ WIP ] support async #26

Closed ngot closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #26 into master will decrease coverage by 35.44%. The diff coverage is 23.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #26       +/-   ##
===========================================
- Coverage   86.75%   51.31%   -35.45%     
===========================================
  Files          35       35               
  Lines        1714     1713        -1     
===========================================
- Hits         1487      879      -608     
- Misses        227      834      +607
Impacted Files Coverage Δ
lib/store/local_memory.js 100% <ø> (ø) :arrow_up:
lib/consumer/mq_push_consumer.js 7.5% <0%> (-76.4%) :arrow_down:
lib/store/local_file.js 70.58% <100%> (-5.89%) :arrow_down:
lib/channel.js 34.14% <100%> (-65.86%) :arrow_down:
lib/store/remote_broker.js 7.14% <11.11%> (-88.58%) :arrow_down:
lib/mq_client_api.js 22.77% <33.33%> (-44.06%) :arrow_down:
lib/mq_client.js 49.48% <48.48%> (-34.71%) :arrow_down:
lib/producer/mq_producer.js 28.31% <50%> (-56.03%) :arrow_down:
lib/remoting_client.js 87.09% <75%> (-8.07%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 583209b...e0a7a77. Read the comment docs.

denghongcai commented 6 years ago

@ngot I submit a new pr #31 , close this?

ngot commented 6 years ago

@denghongcai definitely