ali-sdk / ali-ons

Aliyun Open Notification Service Client
MIT License
151 stars 43 forks source link

chore: reduce error #64

Closed denghongcai closed 4 years ago

denghongcai commented 5 years ago

减少不必要报错

codecov[bot] commented 5 years ago

Codecov Report

Merging #64 into master will decrease coverage by 27.33%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #64       +/-   ##
===========================================
- Coverage   91.48%   64.15%   -27.34%     
===========================================
  Files          35       35               
  Lines        1809     1816        +7     
===========================================
- Hits         1655     1165      -490     
- Misses        154      651      +497
Impacted Files Coverage Δ
lib/remoting_client.js 94.93% <100%> (-0.52%) :arrow_down:
lib/mq_client_api.js 26.79% <100%> (-50.89%) :arrow_down:
lib/producer/topic_publish_info.js 35.29% <0%> (-58.83%) :arrow_down:
lib/process_queue.js 20.83% <0%> (-58.34%) :arrow_down:
lib/producer/mq_producer.js 40% <0%> (-55.2%) :arrow_down:
lib/consumer/mq_push_consumer.js 41.86% <0%> (-50.88%) :arrow_down:
lib/mq_client.js 54.48% <0%> (-33.8%) :arrow_down:
lib/store/remote_broker.js 85.71% <0%> (-11.43%) :arrow_down:
lib/message/message.js 90.69% <0%> (-9.31%) :arrow_down:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 453a57e...9655c4f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #64 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   91.55%   91.62%   +0.07%     
==========================================
  Files          35       35              
  Lines        1812     1816       +4     
==========================================
+ Hits         1659     1664       +5     
+ Misses        153      152       -1
Impacted Files Coverage Δ
lib/remoting_client.js 96.2% <100%> (+0.74%) :arrow_up:
lib/mq_client_api.js 77.03% <100%> (-0.65%) :arrow_down:
lib/mq_client.js 88.27% <0%> (-0.35%) :arrow_down:
lib/message/message_const.js 100% <0%> (ø) :arrow_up:
lib/message/message.js 100% <0%> (ø) :arrow_up:
lib/consumer/mq_push_consumer.js 93.31% <0%> (+0.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 073058b...ebee518. Read the comment docs.

gxcsoccer commented 5 years ago

加一个用例吧,其他 +1

denghongcai commented 5 years ago

加一个用例吧,其他 +1

加了个单测