Closed MarvinWilliam closed 5 years ago
ci 很多 AuthenticationException
RemotingCommand{code:1,customHeader:undefined,flag:1,opaque:1,remark:"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException: com.alibaba.ons.open.exception.OnsException: __accessKey is blank.,
ci 很多 AuthenticationException
RemotingCommand{code:1,customHeader:undefined,flag:1,opaque:1,remark:"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException: com.alibaba.ons.open.exception.OnsException: __accessKey is blank.,
他这个报错是因为 ci 是在他自己的配置下跑的,没 accesskey 这些环境变量
Merging #68 into master will decrease coverage by
31.62%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 91.55% 59.93% -31.63%
===========================================
Files 35 35
Lines 1812 1822 +10
===========================================
- Hits 1659 1092 -567
- Misses 153 730 +577
Impacted Files | Coverage Δ | |
---|---|---|
lib/producer/mq_producer.js | 41.86% <100%> (-53.34%) |
:arrow_down: |
lib/client_config.js | 100% <100%> (ø) |
:arrow_up: |
lib/consumer/mq_push_consumer.js | 42.97% <100%> (-49.76%) |
:arrow_down: |
lib/store/remote_broker.js | 15.71% <0%> (-81.43%) |
:arrow_down: |
lib/producer/topic_publish_info.js | 35.29% <0%> (-58.83%) |
:arrow_down: |
lib/process_queue.js | 20.83% <0%> (-58.34%) |
:arrow_down: |
lib/mq_client_api.js | 24.18% <0%> (-53.49%) |
:arrow_down: |
lib/channel.js | 46.66% <0%> (-53.34%) |
:arrow_down: |
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 073058b...3ce5109. Read the comment docs.
Merging #68 into master will decrease coverage by
31.62%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 91.55% 59.93% -31.63%
===========================================
Files 35 35
Lines 1812 1822 +10
===========================================
- Hits 1659 1092 -567
- Misses 153 730 +577
Impacted Files | Coverage Δ | |
---|---|---|
lib/producer/mq_producer.js | 41.86% <100%> (-53.34%) |
:arrow_down: |
lib/client_config.js | 100% <100%> (ø) |
:arrow_up: |
lib/consumer/mq_push_consumer.js | 42.97% <100%> (-49.76%) |
:arrow_down: |
lib/store/remote_broker.js | 15.71% <0%> (-81.43%) |
:arrow_down: |
lib/producer/topic_publish_info.js | 35.29% <0%> (-58.83%) |
:arrow_down: |
lib/process_queue.js | 20.83% <0%> (-58.34%) |
:arrow_down: |
lib/mq_client_api.js | 24.18% <0%> (-53.49%) |
:arrow_down: |
lib/channel.js | 46.66% <0%> (-53.34%) |
:arrow_down: |
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 073058b...3ce5109. Read the comment docs.
@gxcsoccer @denghongcai 麻烦帮我跑下吧,这个namespace需要创建新的非default阿里云rocketmq实例
其实这个 namespace 只是往 group 和 topic 前加了东西,感觉也不用改代码?
@denghongcai 对,是在 group 和 topic 前拼接了实例id,不影响原有逻辑,我是想保持阿里云rocketmq几个sdk调用方式的统一
这个在 egg-ons 插件里面改吧,没必要在基础库里做了
@gxcsoccer 嗯,那我调整一下
@gxcsoccer 如果在egg-ons里面处理namespace,面对默认group的初始化方式,egg-ons还需要来拿ali-ons中默认group的值再拼接上namespace,但是ali-ons默认的group名字并不对外暴露,我考虑了下,觉得这个namespace还是要在基础库里处理
@MarvinWilliam https://github.com/eggjs/egg-ons/blob/master/lib/ons.js 在这里面拼接就好了吧
@MarvinWilliam 这个功能由官方的文档吗?
这个可以 reopen,但是要想办法把单测搞好
增加对阿里云自创建实例的支持