search

ali1234 / vhs-teletext

Software to recover teletext data from VHS recordings.
GNU General Public License v3.0
203 stars 22 forks source link

filter allows incompatible options #29

Closed ZXGuesser closed 5 years ago

ZXGuesser commented 5 years ago

running filter with a non zero -r prevents it from matching any pages/subpages to -p and -s

ali1234 commented 5 years ago

This happens because the row filtering is applied before pagination/page filtering. If row filtering removes headers, then the stream can't be paginated.

There is one small problem with this: the packet stream is filtered by a decorator before it even reaches the part of the code that needs headers. So the header-using code can't tell if rows have been filtered or not.

The easiest way around this is to add an extra argument: just a bool that indicates if headers have been filtered or not.