search

ali1234 / vhs-teletext

Software to recover teletext data from VHS recordings.
GNU General Public License v3.0
179 stars 21 forks source link

Add support for cyrillic render to HTML #60

Closed ZXByteman closed 3 years ago

ZXByteman commented 3 years ago

Hi Ali,

There is a bit rough implementation for cyrillic support in html render. Oprion "cyrillic" was added, character set is Cyrillic G0 Set - Option 2 (Russian/Bulgarian).

Regards, Alexander

ZXByteman commented 3 years ago

I've forgot to mention that in this fix I've also submitted a change to header render, I've shifted page number one letter to the left because on many services this page number was "glued" to the header title. Like this:

image

ali1234 commented 3 years ago

The thing with "P100" is actually a bug. Last commit to that line broke it.

The rest of this I feel should be implemented in a way that allows to easily add more code pages. Probably by putting all the code pages into a dict and selecting one from the CLI.

ZXByteman commented 3 years ago

Hi Ali,

I've made an update to "cyrillic" branch. Now "--cyrillic" switch is replaced with "--localcodepage" where codepage should be passed as string. Character set g0 was rearranged as a dict with "default" charset used as before and "cyr" charset used for "localcodepage". Polish, German etc. codepages could be added to have support for printing them to HTML.

Regards, Alexander

ali1234 commented 3 years ago

Thanks!

It might be after Christmas before I can properly look at this and merge it.

ZXByteman commented 3 years ago

Thank you, I'm looking forward to it :)

ZXByteman commented 3 years ago

Hi Ali,

Let me kindly remind about my pull request 🙂

Thanks, Alexander

ali1234 commented 3 years ago

Why is the default None instead of 'default'? Wouldn't that make it much easier?

ali1234 commented 3 years ago

Merging this as-is for now. I squashed the letter fix.