search

ali5h / rules_pip

pip package rules for bazel that are fast (incremental fetch), support different python versions and work with all kinds of packages (i.e. packages with namespaces)
MIT License
60 stars 23 forks source link

Feature request: Allow custom BUILD file content to be appended to generated BUILD. #40

Closed sohaibiftikhar closed 4 years ago

sohaibiftikhar commented 4 years ago

For some python modules that depend on shared libraries written in C++ such as Tensorflow sometimes it is necessary to allow declaration of targets a bit differently. Or to add additional targets such as filegroups. Currently this is not customizable through rules_pip. It would be nice to allow this using an additional parameter to the pip_import rule.

sohaibiftikhar commented 4 years ago

@ali5h Is this the same as #6 ?

ali5h commented 4 years ago

yes

sohaibiftikhar commented 4 years ago

Closing this in favour of #6