[REVIEW] Astropackage

[xuanxu]

Submitting Author: JJ (!--author-handle-->@AUTHOR_GITHUB_HANDLE<!--end-author-handle--)
Repository: https://github.com/KathrynJones1/catwoman
Version submitted: 3.3

Editor: !--editor-->@xuanxu<!--end-editor--
Reviewers: !--reviewers-list-->@gemgon<!--end-reviewers-list--

Due date for @gemgon: 2021-03-12

Archive: TBD
Version accepted: v1.2.3

---

Description

catwoman is a Python package that models asymmetric transit lightcurves 
where planets are modelled as two semi-circles with different radii in any orientation, 
for any radially symmetric stellar limb darkening law.

catwoman uses the integration algorithm developed for the batman package (Kreidberg 2015), 
from which catwoman builds upon.

Scope

• Please indicate which category or categories this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):

  • [ ] data retrieval
  • [ ] scientific software wrappers
  • [x] field and lab reproducibility tools
  • [ ] geospatial data
  • [ ] text analysis

• Explain how and why the package falls under these categories (briefly, 1-2 sentences):

Technical checks

Confirm each of the following by checking the box.
This package:

• [x] does not violate the Terms of Service of any service it interacts with.
• [x] has a CRAN and OSI accepted license.
• [x] contains a README with instructions for installing the development version.
• [x] includes documentation.
• [x] has a test suite.
• [x] has continuous integration.

Code of conduct

• [x] I agree to abide by our Code of Conduct during the review process and in maintaining my package should it be accepted.

[botsci]

Welcome xuanxu, thanks for opening this issue :tada:

Thanks for sending your software to aliadalabs/sunnydale

[xuanxu]

@botsci help

[botsci]

Hello @xuanxu, here are the things you can ask me to do:

# List all available commands
@botsci help

# Show our community Code of Conduct and Guidelines
@botsci code of conduct

# List all current topic editors
@botsci list editors

# Assign a user as the reviewer N of this submission (where N=1,2...)
@botsci assign @username as reviewer 2

# Remove the user assigned as reviewer N of this submission (where N=1,2...)
@botsci remove reviewer 2

# Add to this issue's reviewers list
@botsci add @username to reviewers

# Remove from this issue's reviewers list
@botsci remove @username from reviewers

# Assign a user as the editor of this submission
@botsci assign @username as editor

# Remove the editor assigned to this submission
@botsci remove editor

# Send an invitation to a user to collaborate in the review
@botsci invite @username

# Add a user to this issue's assignees list
@botsci add assignee: @username

# Remove a user from this issue's assignees list
@botsci remove assignee: @username

# Check the references of the paper for missing DOIs
# Optionally, it can be run on a non-default branch 
@botsci check references
@botsci check references from custom-branch-name

# Perform checks on the repository
# Optionally, it can be run on a non-default branch 
@botsci check repository
@botsci check repository from custom-branch-name

# Set a value for version
@botsci set v1.0.0 as version

# Set a value for archive
@botsci set 10.21105/joss.12345 as archive

# Label issue with: reviewed, recommend publication, pending publication. Remove labels: ongoing, pending review
@botsci review successful

# Label issue with: recommend rejection
@botsci review failed

# Close the issue
@botsci reject

# Reports on the quality of the code
@botsci analyze code

# Random facts about cats
@botsci tell me something about cats

# Add review checklist for a user
@botsci add checklist for @username

# Remove the checklist for a user
@botsci remove checklist for @username

[xuanxu]

@botsci list editors

[botsci]

Here is the list of current topic editors:

Astronomy

- astroeditor_33
- astro_editor_2

Social science

- sociology_editor_1
- sociology_editor_2

Genomics

- @xuanxu
- genomics_editor_7

Machine Learning

- Alice
- Bob

Thanks for asking, xuanxu.

[xuanxu]

@botsci assign me as editor

[botsci]

Assigned! @xuanxu is now the editor

[xuanxu]

@botsci check references

[botsci]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1086/683602 is OK
- 10.1086/345520 is OK
- 10.3847/1538-3881/aae8e5 is OK
- 10.3847/1538-4357/ab55d9 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[xuanxu]

@botsci check repository

[botsci]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.33 s (251.0 files/s, 125584.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      22           3484           2741          13021
CSS                             14           1133            160          11054
Sass                             7            249            278           2516
SVG                              6              0              0           2405
HTML                             6             51              0            755
C                                8            220            259            690
Python                           5            145            250            449
C/C++ Header                     1            101             36            442
reStructuredText                 7            127             44            206
TeX                              1              8              0             72
Markdown                         1             13              0             40
DOS Batch                        1              8              1             26
Ruby                             1              5              4             11
make                             1              4              6              9
TOML                             1              2              0              2
-------------------------------------------------------------------------------
SUM:                            82           5550           3779          31698
-------------------------------------------------------------------------------

Statistical information for the repository '4925c850699c3edf6b82ed36' was
gathered on 2020/11/30.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Brett M. Morris                  1             1              1            0.00
Brett Morris                     3            86              8            0.12
Dan Foreman-Mackey               1             0              1            0.00
Ethan Kruse                      5            87             84            0.21
Geert Barentsen                  1             1              1            0.00
Karl Fogel                       1           876              2            1.09
Kathryn Jones                  210         47573          13993           76.17
Laura Kreidberg                195         13289           3765           21.10
Michael Zhang                   13           419            612            1.28
Nestor Espinoza                  3             7              9            0.02
Simon Walker                     2             5              3            0.01
iancrossfield                    1             3              4            0.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Brett Morris                 29           33.7         58.7                6.90
Geert Barentsen               1          100.0          3.4                0.00
Karl Fogel                  740           84.5         64.6               10.00
Kathryn Jones             40903           86.0         14.0                7.12
Laura Kreidberg            1221            9.2         60.4               17.69
Michael Zhang               234           55.8         43.0               14.10
Simon Walker                  4           80.0         47.8                0.00

[botsci]

Failed to discover a Statement of need section in paper

[xuanxu]

@botsci tell me something about cats

[botsci]

Here is a random fact about cats:

😺😺 Cats were mythic symbols of divinity in ancient Egypt. 😸😸

[xuanxu]

@botsci set v1.2.3 as version

[botsci]

Done! version is now v1.2.3

[xuanxu]

@botsci add @gemgon to reviewers

[botsci]

@gemgon added to the reviewers list!

[xuanxu]

@botsci analyze code

[botsci]

Inspecting code...

[botsci]

The quality of the code in is quite the best

[xuanxu]

Thanks @botsci!

[botsci]

You are welcome

[xuanxu]

@botsci unknown command

[xuanxu]

@botsci remove @gemgon from reviewers

[botsci]

@gemgon removed from the reviewers list!

[xuanxu]

@botsci add @gemgon to reviewers

[botsci]

@gemgon added to the reviewers list!

[xuanxu]

@botsci check repository

[botsci]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.23 s (355.1 files/s, 177644.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      22           3484           2741          13021
CSS                             14           1133            160          11054
Sass                             7            249            278           2516
SVG                              6              0              0           2405
HTML                             6             51              0            755
C                                8            220            259            690
Python                           5            145            250            449
C/C++ Header                     1            101             36            442
reStructuredText                 7            127             44            206
TeX                              1              8              0             72
Markdown                         1             13              0             40
DOS Batch                        1              8              1             26
Ruby                             1              5              4             11
make                             1              4              6              9
TOML                             1              2              0              2
-------------------------------------------------------------------------------
SUM:                            82           5550           3779          31698
-------------------------------------------------------------------------------

Statistical information for the repository 'ef087a07f024c3a6b600783d' was
gathered on 2021/01/28.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Brett M. Morris                  1             1              1            0.00
Brett Morris                     3            86              8            0.12
Dan Foreman-Mackey               1             0              1            0.00
Ethan Kruse                      5            87             84            0.21
Geert Barentsen                  1             1              1            0.00
Karl Fogel                       1           876              2            1.09
Kathryn Jones                  210         47573          13993           76.17
Laura Kreidberg                195         13289           3765           21.10
Michael Zhang                   13           419            612            1.28
Nestor Espinoza                  3             7              9            0.02
Simon Walker                     2             5              3            0.01
iancrossfield                    1             3              4            0.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Brett Morris                 29           33.7         58.7                6.90
Geert Barentsen               1          100.0          3.4                0.00
Karl Fogel                  740           84.5         64.6               10.00
Kathryn Jones             40903           86.0         14.0                7.12
Laura Kreidberg            1221            9.2         60.4               17.69
Michael Zhang               234           55.8         43.0               14.10
Simon Walker                  4           80.0         47.8                0.00

[botsci]

Failed to discover a Statement of need section in paper

[xuanxu]

@botsci help

[botsci]

Hello @xuanxu, here are the things you can ask me to do:

# List all available commands
@botsci help

# Show our community Code of Conduct and Guidelines
@botsci code of conduct

# List all current topic editors
@botsci list editors

# Assign a user as the reviewer N of this submission (where N=1,2...)
@botsci assign @username as reviewer 2

# Remove the user assigned as reviewer N of this submission (where N=1,2...)
@botsci remove reviewer 2

# Add to this issue's reviewers list
@botsci add @username to reviewers

# Remove from this issue's reviewers list
@botsci remove @username from reviewers

# Assign a user as the editor of this submission
@botsci assign @username as editor

# Remove the editor assigned to this submission
@botsci remove editor

# Send an invitation to a user to collaborate in the review
@botsci invite @username

# Add a user to this issue's assignees list
@botsci add assignee: @username

# Remove a user from this issue's assignees list
@botsci remove assignee: @username

# Check the references of the paper for missing DOIs
# Optionally, it can be run on a non-default branch 
@botsci check references
@botsci check references from custom-branch-name

# Perform checks on the repository
# Optionally, it can be run on a non-default branch 
@botsci check repository
@botsci check repository from custom-branch-name

# Set a value for version
@botsci set v1.0.0 as version

# Set a value for archive
@botsci set 10.21105/joss.12345 as archive

# Label issue with: reviewed, recommend publication, pending publication. Remove labels: ongoing, pending review
@botsci review successful

# Label issue with: recommend rejection
@botsci review failed

# Close the issue
@botsci reject

# Reports on the quality of the code
@botsci analyze code

# Random facts about cats
@botsci tell me something about cats

# Add review checklist for a user
@botsci add checklist for @username

# Remove the checklist for a user
@botsci remove checklist for @username

[xuanxu]

@botsci analyze code

[botsci]

Inspecting code...

[botsci]

The quality of the code in https://github.com/KathrynJones1/catwoman is not the best

[xuanxu]

@botsci check repository

[botsci]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.44 s (185.3 files/s, 92698.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      22           3484           2741          13021
CSS                             14           1133            160          11054
Sass                             7            249            278           2516
SVG                              6              0              0           2405
HTML                             6             51              0            755
C                                8            220            259            690
Python                           5            145            250            449
C/C++ Header                     1            101             36            442
reStructuredText                 7            127             44            206
TeX                              1              8              0             72
Markdown                         1             13              0             40
DOS Batch                        1              8              1             26
Ruby                             1              5              4             11
make                             1              4              6              9
TOML                             1              2              0              2
-------------------------------------------------------------------------------
SUM:                            82           5550           3779          31698
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[botsci]

Failed to discover a Statement of need section in paper

[xuanxu]

Thanks @botsci!

[botsci]

You are welcome

[gemgon]

@botsci help

[botsci]

Hello @gemgon, here are the things you can ask me to do:

# List all available commands
@botsci help

# Show our community Code of Conduct and Guidelines
@botsci code of conduct

# List all current topic editors
@botsci list editors

# Check the references of the paper for missing DOIs
# Optionally, it can be run on a non-default branch 
@botsci check references
@botsci check references from custom-branch-name

# Perform checks on the repository
# Optionally, it can be run on a non-default branch 
@botsci check repository
@botsci check repository from custom-branch-name

# Random facts about cats
@botsci tell me something about cats

[gemgon]

@botsci remove editor

[botsci]

I'm sorry @gemgon, I'm afraid I can't do that. That's something only editors are allowed to do.

[xuanxu]

@botsci help

[botsci]

Hello @xuanxu, here are the things you can ask me to do:

# List all available commands
@botsci help

# Show our Code of Conduct
@botsci code of conduct

[xuanxu]

@botsci remove @gemgon to reviewers

[botsci]

I'm sorry @xuanxu, I'm afraid I can't do that. That's something only editors and maelle are allowed to do.

[xuanxu]

@botsci help