search

aliaksei135 / seedpod_ground_risk

Ground Risk model for UAS flight path analysis and risk-aware path finding
MIT License
6 stars 2 forks source link

Fix graph regen #66

Closed Zach10a closed 2 years ago

Zach10a commented 2 years ago

This PR adds more URLs for the program to try upon one of them not responding correctly. It also now displays a message to the user giving them the error that has occurred and asking them to regenerate the plot.

It should be noted that something has happened recently which means that the SSL certificate was throwing errors when trying to access the Overpass API. Until I figure out how we can fix this the varify flag has been set to False. As no secure data is being transmitted this should be ok for now, however, if we have to start using API keys then this needs to be fixed.

aliaksei135 commented 2 years ago

CI tests also fail due to a FileNotFoundError. This doesn't seem related to any OSM query problems...

Zach10a commented 2 years ago

So this PR now cycles through all of the global instances allowed by Overpass. It appears something has changed with their system that sometimes causes issues with connection, however, when this happens the user is now given the error and promoted to regenerate. I'll keep looking to find the change that's happened with the API.

aliaksei135 commented 2 years ago

Have you tried reverting to something like v0.11.0 and seeing if the same problem exists? If that works I suggest a git bisect would be in order :)

Zach10a commented 2 years ago

Tried releases all the way back to v0.11.0, fairly sure this is an issue with the Overpass servers.Seen a couple of comments online saying they are quite busy.

Zach10a commented 2 years ago

It appears changing it from a GET request to a POST request has worked. The comment with this research (from @aliaksei135 ) is linked here

Zach10a commented 2 years ago

Changed headers as requested

Zach10a commented 2 years ago

This is ready to rumble, merging sooner rather than later would be ideal!