alialbaali / Noto

Minimal Note-Taking App
https://play.google.com/store/apps/details?id=com.noto
Apache License 2.0
499 stars 26 forks source link

During multi-selection: Just holding a label changes its status. #206

Closed uli-on closed 1 year ago

uli-on commented 1 year ago

Just holding and subsequently sliding out of the label changes the label status. That's not expected and undesirable cause it can not be undone to the original state if the initial situation comprised notes of mixed labels and label status, and one of the only partially assigned labels was involved/held.

Noto v2.3.0-beta2 Fairphone 3 Android 10 with GMS updated to v23.13.12

alialbaali commented 1 year ago

Could you please provide a screenshot/screencast to help me understand the issue better?

uli-on commented 1 year ago

The demo setup is two notes two labels. Each note has only one different label assigned.

I've switched on tap marks, so you can see when I touch and when I let go, and where.

https://github.com/alialbaali/Noto/assets/35634829/b3ddfde1-abb2-4f17-8ca8-b844e048eb82

alialbaali commented 1 year ago

I see what you mean. That's basically long clicking on the label changes the status. If you think long clicking isn't helpful in this case, I could disable it.

uli-on commented 1 year ago

That!

alialbaali commented 1 year ago

Done!

uli-on commented 1 year ago

Thanks!

alialbaali commented 1 year ago

You’re welcome!

uli-on commented 1 year ago

Fixed, hooray! That made hesitantly scrolling a plague.