search

aliariff / vscode-auto-add-brackets

Automatically add complete brackets when writing interpolated string
https://marketplace.visualstudio.com/items?itemName=aliariff.auto-add-brackets
MIT License
10 stars 4 forks source link

Fix Vim mode #6

Closed taylon closed 5 years ago

taylon commented 5 years ago

VSCode's when clauses in keybindings do not support parenthesis, because of that Vim mode support does not work correctly and inserts the interpolation symbol even on Normal/Visual mode.

Unfortunately VSCode also does not support 'or/||' so the only way to support this properly is to add one '!=' for each vim mode we want to disable.

aliariff commented 5 years ago

Hi @taylon

Thanks for the pull request, is it possible that we have test for this?

taylon commented 5 years ago

Hey @aliariff, sorry for the delay on this. I'm not sure if adding tests to it would be trivial, I don't think it would. But unfortunately I won't be able to look more into it any time soon :(

Since there is currently no tests for this anyway, and this is literally a bug that breaks the extension entirely for Vim users, I would just merge this and add an issue for adding tests later.